DV Info Net

DV Info Net (https://www.dvinfo.net/forum/)
-   Final Cut Suite (https://www.dvinfo.net/forum/final-cut-suite/)
-   -   Photoshop curves for Final Cut (https://www.dvinfo.net/forum/final-cut-suite/485713-photoshop-curves-final-cut.html)

Dominik Seibold October 5th, 2010 02:27 PM

Photoshop curves for Final Cut
 
I'm about to write a plugin for Final Cut which should imitate the Photoshop RGB-Curves. But I have one problem/question which I just can't get answered even with extreme googleing:
What is the interpolation-formula Photoshops curves uses to interpolate between the points?
It seems to me that Photoshops curves inpolation is both unique out of all curves out there (Apple Color, etc.) and best regarding the photographic quality compared to the effort to tweak a curve. Other implementations of such curves-tools often use interpolation-schemes like Bezier, but they feel really inadequate for this application. So I absolutely want to implement the interpolation like Photoshops curves does, but I have absolutely no idea what the formula could look like.

William Hohauser October 5th, 2010 04:49 PM

Be careful, it might be patented.

Dominik Seibold October 5th, 2010 10:06 PM

1 Attachment(s)
The plugin is now almost done. You can download and test it here:
http://www.dominik.ws/rgbcurves.zip
I also attached a screenshot of it to this post.
The only missing thing is a good interpolation between the points. Currently linear interpolation is used. If someone of you could give me a hint what kind if interpolation I should implement, I will do it! :) Please give me some feedback what you think about the plugin!

Chuck Spaulding October 6th, 2010 12:22 AM

That's a great idea. I always thought they were just B-splines. I think it would be a lot more useful if you could edit the curves directly, break them at the point so they can linear in and Bezier out.

I thought Apple started improving their graph editor, it was good for a while in variable speed, but it never really went anywhere.

Is there a high-pass filter in FCP? That's a good filter for sharpening, if your taking requests...

Dean Sensui October 7th, 2010 03:32 AM

A suggestion: Use Color.

It already has curves and is an immensely powerful color correction tool.

Dominik Seibold October 7th, 2010 05:40 AM

1 Attachment(s)
Quote:

Originally Posted by Chuck Spaulding (Post 1575997)
I always thought they were just B-splines.

Thank you! I finally discovered that Photoshops curves uses so called "natural cubic splines". I implemented them now into my plugin. Here you can download and install the result (I used fxplug sdk 1.2.5):
http://www.dominik.ws/rgbcurves.zip
Btw., a 16bit (unsigned short) per channel lookup-table is internally generated and used, so the image processing is fast and posterizing free (but not GPU accelerated right now. If you know how to write an ARB fragment shader which uses a lookup table, please let me know!).
A sreenshot is attached to this post which shows the plugin in action.
Please give me some feedback!

Quote:

Originally Posted by Chuck Spaulding (Post 1575997)
Is there a high-pass filter in FCP? That's a good filter for sharpening, if your taking requests...

What kind of high-pass filter? Like the simple sharpening filter or more like unsharp mask?

Quote:

Originally Posted by Dean Sensui (Post 1576385)
A suggestion: Use Color.

I don't like the behaviour of Colors Curves. Also I don't like to even start Color up. I think the workflow is very inconvenient.

William Hohauser October 7th, 2010 01:09 PM

Your filter sounds good but the download installer file seems to be empty, only 16k. Could you post the filter without the installer package?

Simon Denny October 7th, 2010 01:25 PM

Thanks Dominik,

Plugin works great and I like it. Is there anyway to add a point to the curve rather than adding a point as it moves. I say this because as I add a point the cure moves and I may not want to add a point in that spot.

Cheers

Dominik Seibold October 7th, 2010 01:29 PM

Quote:

Originally Posted by William Hohauser (Post 1576547)
Your filter sounds good but the download installer file seems to be empty, only 16k. Could you post the filter without the installer package?

Well, the installer isn't empty, but of course (I guess it's a trust issue) I can also give you the raw fxplug File/Folder:
http://www.dominik.ws/rgbcurves2.zip

Dominik Seibold October 7th, 2010 01:45 PM

Quote:

Originally Posted by Simon Ash (Post 1576554)
Is there anyway to add a point to the curve rather than adding a point as it moves.

I just added this feature. With the right mouse button you can now add a point which initially doesn't alter the curve (x value comes from your mouse, y value from the current curve). I already updated the files rgbcurves.zip and rgbcurves2.zip on my server, so you can immediatelly download the new version.

William Hohauser October 7th, 2010 08:26 PM

Quote:

Originally Posted by Dominik Seibold (Post 1576556)
Well, the installer isn't empty, but of course (I guess it's a trust issue) I can also give you the raw fxplug File/Folder:
http://www.dominik.ws/rgbcurves2.zip

It's not that, but it didn't install after running it. But thanks for the direct plug-in. I'm going to try it now.

William Hohauser October 7th, 2010 08:53 PM

Not to be a nuisance but the plug-in unzipped as a folder.

Dominik Seibold October 7th, 2010 10:26 PM

Quote:

Originally Posted by William Hohauser (Post 1576680)
Not to be a nuisance but the plug-in unzipped as a folder.

Yes, you have to copy that folder to /Library/Plug-Ins/FxPlug (or ~/Library/Plug-Ins/FxPlug). But I guess the folder is already there, because you already executed the installer package. I'm not sure why my plugin isn't shown in your plugin-list. Which version of Final Cut do you have?

Simon Denny October 8th, 2010 02:30 AM

Hi Dominik,

Where can I find the updated cures version for downloading?

Cheers

Anthony J. Howe October 8th, 2010 05:28 AM

I have been testing this Dominik, and it works great, what a great time-saver and so easy to use.
Well done and thanks.

Dominik Seibold October 8th, 2010 08:28 AM

Quote:

Originally Posted by Simon Ash (Post 1576731)
Where can I find the updated cures version for downloading?

Same address as the older:
http://www.dominik.ws/rgbcurves.zip

@William
Try downloading and installing it again. I've changed its "group-uuid", which is responsible for identifying the different plugin-categories. The last version had a default one, which perhaps conflicted with another plugin you have installed.

William Hohauser October 8th, 2010 11:19 AM

Quote:

Originally Posted by Dominik Seibold (Post 1576692)
Yes, you have to copy that folder to /Library/Plug-Ins/FxPlug (or ~/Library/Plug-Ins/FxPlug). But I guess the folder is already there, because you already executed the installer package. I'm not sure why my plugin isn't shown in your plugin-list. Which version of Final Cut do you have?

FCP 7 on a MacPro. However, I just downloaded the new installer on my laptop and your plug-in loaded like a charm. Works great. I'll try to reinstall it on the MacPro later. That's the machine I'll use it on.

Thank you for the hard work that went into it.

Simon Denny October 8th, 2010 02:42 PM

Thanks Dominik,

The plugin works great. I have been looking for a plugin like this for a long time. Thanks for the research and development on this and keep up the good work.

Cheers

Chuck Spaulding October 14th, 2010 05:37 PM

Quote:

Originally Posted by Dominik Seibold (Post 1576692)
Yes, you have to copy that folder to /Library/Plug-Ins/FxPlug (or ~/Library/Plug-Ins/FxPlug). But I guess the folder is already there, because you already executed the installer package. I'm not sure why my plugin isn't shown in your plugin-list. Which version of Final Cut do you have?

Hi Dominik, I'm on a MacPro as well, everything seemed to install OK but the plug-in doesn't appear in my effects palette. There is a folder installed at /Library/Plug-Ins/FxPlug/RGBCurves.fxplug.

Regarding the Hi-Pass filter, I guess I use it more like an unsharp mask, I duplicate the layer, set the Hi-Pass filter and then change the transfer mode, that way I can dial in the sharpening. That way you can get some subtle edge sharpening without adding a lot of noise. I shoot mostly with the 7D and with the still this method of sharpening works really well, I'm guessing that the video from this camera would benefit from this too.

Now I'm using the sharpening in Color which is OK, but it doesn't really compare to what I can do to a still in Photoshop using the Hi-Pass filter.

Dominik Seibold October 15th, 2010 03:51 AM

Quote:

Originally Posted by Chuck Spaulding (Post 1578803)
Hi Dominik, I'm on a MacPro as well, everything seemed to install OK but the plug-in doesn't appear in my effects palette. There is a folder installed at /Library/Plug-Ins/FxPlug/RGBCurves.fxplug.

Please download and try it again. I've now disabled the localization-option. I don't know if that helps, but let's do trial and error. ;) Btw. which version of Final Cut do you have?
Quote:

Originally Posted by Chuck Spaulding (Post 1578803)
Regarding the Hi-Pass filter, I guess I use it more like an unsharp mask, I duplicate the layer, set the Hi-Pass filter and then change the transfer mode, that way I can dial in the sharpening. That way you can get some subtle edge sharpening without adding a lot of noise. I shoot mostly with the 7D and with the still this method of sharpening works really well, I'm guessing that the video from this camera would benefit from this too.

Now I'm using the sharpening in Color which is OK, but it doesn't really compare to what I can do to a still in Photoshop using the Hi-Pass filter.

But Final Cut has an unsharp mask filter. So you need a high-pass filter?

Josh Bass March 13th, 2011 03:12 PM

Re: Photoshop curves for Final Cut
 
I know this is somewhat old news, but I'd like to play with it and can't get FCP to recognize it? I"m on FCP 6, by the way.

There is indeed a library/plugins/fxplug/rgbcurves.fxplug folder, but don't see it in FCP.

Nuno Ferreira March 25th, 2011 05:57 AM

Re: Photoshop curves for Final Cut
 
Same problem here.
Can’t make it work. It installed in library/plugins/fxplug/rgbcurves.fxplug folder, but nothing shows up in Final Cut Pro.
I’m using a Mac Pro with FCP 6.

Josh Bass March 25th, 2011 02:15 PM

Re: Photoshop curves for Final Cut
 
I just tried emailing him directly.

Nuno Ferreira March 26th, 2011 06:02 AM

Re: Photoshop curves for Final Cut
 
Thaks Josh.
I'll wait for feedback then.

Aric Mannion March 27th, 2011 01:34 PM

Re: Photoshop curves for Final Cut
 
This is a great thing to have... I usually use just the level corrections in photoshop (and after effects) so that would be really awesome to have. But having curves in FCP is great too, thanks.

Nuno Ferreira March 28th, 2011 07:39 AM

Re: Photoshop curves for Final Cut
 
Hey Aric, did you manage to get it to work?

Pete Stone April 4th, 2011 07:38 PM

Re: Photoshop curves for Final Cut
 
I got it to work........I had to change the sharing and permissions in the "Get Info" box to read and write for me. Otherwise, the folder was locked.
Pete Stone

Josh Bass April 4th, 2011 08:55 PM

Re: Photoshop curves for Final Cut
 
Can you elaborate? Where is this magic box?

Josh Bass April 4th, 2011 09:24 PM

Re: Photoshop curves for Final Cut
 
I think I did what you said. . .(me) and "staff" have read & write permissions ("everyone only lets you select "read only" or "write only") on the RGBCurves.fxplug, plug ins, and fx plug folders. I'm still not seeing anything in FCP.

This should show up in the effects tab under video filters/neat video, right?

Nuno Ferreira April 6th, 2011 12:47 PM

Re: Photoshop curves for Final Cut
 
Can't make it work. Now if I install it doesn't create a folder anymore. Just a plugin file in the fxplug folder with the name RGBCurves.fxplug. But it doesn't show up in FCP, even if I change the sharing and permissions settings.

Josh Bass April 6th, 2011 03:07 PM

Re: Photoshop curves for Final Cut
 
Ditto. Disappointed, but with tinges of hope.


All times are GMT -6. The time now is 10:17 PM.

DV Info Net -- Real Names, Real People, Real Info!
1998-2024 The Digital Video Information Network